add missing vertical red line on reset #110
Conversation
There was a problem hiding this comment.
Hi @hbsmith,
thanks for taking on this PR. The changes look good to me. Happy to see that you were able to navigate the codebase of our interactive app recipe. :)
I suppose you already tested it on your machine and everything worked as expected. Would it be possible to post a quick screenshot of the result (just pick one of the example models from the docs for it)? That would be a nice way to document the changes.
| @@ -98,6 +98,11 @@ function init_abm_data_plots!(fig, p, adata, mdata, alabels, mlabels, plotkwargs | |||
| ylims!(ax, Makie.MakieLayout.yautolimits(ax)) | |||
| end | |||
| end | |||
| on(resetclick) do clicks | |||
| for ax in axs | |||
| vlines!(ax, [p.s.val], color = "#c41818") | |||
There was a problem hiding this comment.
#c41818
Was this the colour we've used in the earlier version?
There was a problem hiding this comment.
Yeah--I just found the last version of the code that had the colored line, and basically tried to modify it as little as possible to make it work after your refactor.
|
Sure, below are pictures before and after the code change. Before: After: |
|
Thanks, we appreciate this! And thanks @fbanning for the review! |
fixes #107